This repository has been archived by the owner on Aug 6, 2024. It is now read-only.
4회차 과제 PR #32
Open
4회차 과제 PR #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor code
5글자 제한 추가
findstar
suggested changes
Jul 28, 2022
Comment on lines
18
to
23
| private String checkLength(String name){ | ||
| if(name.length()>5){ | ||
| throw new IllegalArgumentException("자동차 이름은 5자를 넘을 수 없습니다."); | ||
| } | ||
| return name; | ||
| } |
There was a problem hiding this comment.
자동차 이름에 대한 제약사항은 Cars 객체가 가지고 있는게 맞을까요? 아니면 Car 객체가 가지고 있는게 맞을까요?
| Set<String> keys = record.getKeys(); | ||
| int max = getMax(record); | ||
| keys.stream() | ||
| .filter(key -> record.getValue(key) == max) |
There was a problem hiding this comment.
record 에서 값을 가져와서 비교하지 말고,
max 를 인자로 하여 질의하는 메소드를 record 객체에 만들어 보면 어떨까요?
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| public class Winner { |
Comment on lines
+6
to
+7
| private static final int MAX_BOUND = 9; | ||
| private static final int MOVABLE_MIN = 4; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.