Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix twitter login #6

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Hotfix twitter login #6

wants to merge 11 commits into from

Commits on Dec 13, 2017

  1. Add username to users in a migration template file.

    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    2645db3 View commit details
    Browse the repository at this point in the history

  2. Remove not null constraint from email in users.

    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    409ce45 View commit details
    Browse the repository at this point in the history

  3. Add unique index to username.

    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    596c66e View commit details
    Browse the repository at this point in the history

  4. Revert "Remove not null constraint from email in users." 

    This reverts commit b28de94.
    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    842a630 View commit details
    Browse the repository at this point in the history

  5. Set the same constrants as lib/generators/sorcery/templates/migration… 

    …/core.rb
    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    80fde0e View commit details
    Browse the repository at this point in the history

  6. Add empty string to email to #create_new_external_user.

    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    1d76bc0 View commit details
    Browse the repository at this point in the history

  7. Add a feature setting empty string to email. 

    This modification is for an external service that doesn't offer email like twitter.
    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    1e42b7b View commit details
    Browse the repository at this point in the history

  8. Add tests of #create_from_provider.

    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    8ff1ad7 View commit details
    Browse the repository at this point in the history

  9. Modify twitter user_info_mapping from email to username.

    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    5e5dbf7 View commit details
    Browse the repository at this point in the history

  10. Remove #custom_create_new_external_user, which is never used.

    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    2fb9646 View commit details
    Browse the repository at this point in the history

  11. Change the email value, '', into "#{SecureRandom.uuid}@example.com" 

    - `"#{provider}-#{uid}@example.com"` breaks backward compatibility because
in wiki it says `create_from_provider(provider)`: it doesn't pass uid.

- `@example.com` makes it easy to check which email is valid or not
    @ebihara99999
    ebihara99999 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    6f7d553 View commit details
    Browse the repository at this point in the history