Fixed fallback not working if elements were in ShadowRoot #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
http://jsbin.com/nacegusuvu/1/edit |
|
Yeah, it works too. I opened PR before your edit and did it a bit different way because I thought it's gonna have better performance but I haven't really tested them side by side. I think this could be closed now, thanks for fixing! BTW: Could you please upload to Bower, it still sees the latest as 1.6 which doesn't have this fix? Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback of Drag N Drop behaviour works on elements in Shadow DOM but only if there's only one ShadowRoot. Sadly, this is not always the case.
My modifications make it work no matter how many ShadowRoots are in the tree.
Here is a comparison:
My fork
Current master
This issue was reported on polymer-sortablejs#25 because usually Polymer uses many ShadowRoots.