Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add scs 0005 project governance #813

Merged
merged 26 commits into from
Dec 12, 2024
Merged

Conversation

fkr
Copy link
Member

@fkr fkr commented Nov 7, 2024

No description provided.

@fkr fkr marked this pull request as draft November 7, 2024 09:12
@fkr fkr force-pushed the feat/add-scs-0005-project-governance branch from ac0b04f to a6cdbdd Compare November 18, 2024 13:22
@garloff
Copy link
Member

garloff commented Nov 26, 2024

This looks good to me, though it's not yet marked "Ready for review".
Maybe hit the button, @fkr , so we can proceed?

@fkr fkr requested a review from garloff December 2, 2024 13:10
@fkr fkr marked this pull request as ready for review December 2, 2024 13:10
@fkr fkr force-pushed the feat/add-scs-0005-project-governance branch from 4cf729b to cff3e8c Compare December 2, 2024 13:10
Copy link
Member

@frosty-geek frosty-geek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fkr fkr requested a review from FriederikeZelke December 2, 2024 13:34
Copy link

@FriederikeZelke FriederikeZelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@fkr
Copy link
Member Author

fkr commented Dec 4, 2024

There is one todo left, that I will add later today:

  • Explain the voting mechanism in more detail and elaborate on how/where the voting is done (heliosvoting.org)

@fkr fkr requested a review from michaelbayr December 5, 2024 11:33
@fkr
Copy link
Member Author

fkr commented Dec 10, 2024

There is one major hurdle that I've not solved yet (also posted to Matrix last week):

We assumed that all egible voters are the people in the github org. However for those we do not have e-mail addesses and as such no easy way of reaching out to them and onboard them into the voting system (which requires e-mail).

@garloff any chance we can somehow map the github members <-> Members of the UCS?

@garloff
Copy link
Member

garloff commented Dec 10, 2024

@garloff any chance we can somehow map the github members <-> Members of the UCS?

We have no github handles stored in UCS.

We currently have full names for all github users in github-manager, we could leverage the fact that we consistently used Firstname.Lastname on UCS. But this would fail for some cases:

  • Some people have multiple names or such, so the username used on UCS may not be obvious from the full name.
  • Not every member of our github Org has been onboarded on UCS -- I expect we would miss out on a handful. Obviously, we can identify these and try to contact them and invite them to UCS/nextcloud.

I am checking whether the github API allows for access for public email addresses of users.
This should be possible (using a PAT). However, it would require that users have a public email set which not all users do.

@garloff
Copy link
Member

garloff commented Dec 10, 2024

I am checking whether the github API allows for access for public email addresses of users. This should be possible (using a PAT). However, it would require that users have a public email set which not all users do.

37 out of 129 Org members have a public mail address set, 92 do not.
Oh, API access with a PAT does allow to retrieve this, yes.

NAMES=`grep login: data.yaml | sed 's/^[^l]*login: //'`
for name in $NAMES; do echo -n "$name: "; curl -sL   -H "Accept: application/vnd.github+json"   -H "Authorization: Bearer github_pat_REDACTED"   -H "X-GitHub-Api-Version: 2022-11-28"   https://api.github.com/users/$name | jq ".email" | tr -d '"'; done | tee mails

@garloff
Copy link
Member

garloff commented Dec 10, 2024

* Some people have multiple names or such, so the username used on UCS may not be obvious from the full name.
* Not every member of our github Org has been onboarded on UCS -- I expect we would miss out on a handful. Obviously, we can identify these and try to contact them and invite them to UCS/nextcloud.

This results in 71 UCS accounts where I expect most of which have functional mail addresses.
58 github SCS Org members can not be found this way. (A few probably could by some heuristics).

FNAMES=`grep name: data.yaml | sed 's/^[^l]*name: //'`
while read first last; do echo -n "$first $last:"; grep username: udm.users | grep -i "$first\\.$last" || echo " null" ; done < <(echo "$FNAMES") > ucs.mails

@garloff
Copy link
Member

garloff commented Dec 10, 2024

With some magic to replace umlauts ... I get to 87 UCS accounts with 42 missing. There's ~ a handful more that can be resolved manually. We could of course require voters to

  • have a public github address OR
  • have a UCS account (and of course offer to onboard folks)
 SEDUML='s/ä/ae/g;s/ö/oe/g;s/ü/ue/g;s/ß/ss/g;s/é/e/g;s/ý/y/g;s/č/c/g;s/Ä/Ae/g;s/Ö/Oe/g;s/Ü/Ue/g'
 while read first last; do if test "$first" = "Dr."; then first=${last%% *}; last=${last# *}; fi; fir=$(echo "$first" | sed "$SEDUML"); las=${last#* }; las=${las%% *}; las=$(echo $las | sed "$SEDUML"); echo -n "$first $last: "; grep username: udm.users | grep -i "$fir\\.$las" | sed 's/ *username: \(.*\)$/\[email protected]/'; if test ${PIPESTATUS[1]} != 0; then echo "null"; fi ; done < <(echo "$FNAMES") > ucs.mails

@fkr
Copy link
Member Author

fkr commented Dec 10, 2024

With some magic to replace umlauts ... I get to 87 UCS accounts with 42 missing. There's ~ a handful more that can be resolved manually. We could of course require voters to

  • have a public github address OR
  • have a UCS account (and of course offer to onboard folks)

I'm tempted to say we do it that way.

@fkr
Copy link
Member Author

fkr commented Dec 10, 2024

thanks for your suggestions @garloff

fkr and others added 7 commits December 10, 2024 22:39
jschoone and others added 9 commits December 10, 2024 22:39
…community call

Thanks to @michaelbayr, @berendt and others who actively participated.

Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Co-authored-by: Kurt Garloff <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Co-authored-by: Kurt Garloff <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
@fkr fkr force-pushed the feat/add-scs-0005-project-governance branch from 4e19991 to 48e079c Compare December 10, 2024 21:39
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
@fkr fkr requested a review from garloff December 10, 2024 21:49
Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Copy link
Member

garloff commented Dec 12, 2024

@michaelbayr - this looks good to me now and I believe your good questions and suggestions have all been addressed.
However, this is for you to judge, of course. github still believes that you have open change requests, so please mark as resolved or approve explicitly to override this.

Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.
Thanks for the excellent work, @fkr, @michaelbayr .

Copy link

@michaelbayr michaelbayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkr @garloff thanks for all the work you put into this!
LGTM!

Copy link
Member

@maxwolfs maxwolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a note on mapping the GitHub Org Roles to SCS Community Members and SCS Project Board Members, with a suggestion for L34-L37. The bullet points can also be removed to be less precise as they are just an idea but could lead to more discussion.

Co-authored-by: Max Wolfs <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
@fkr
Copy link
Member Author

fkr commented Dec 12, 2024

Awesome collaboration - thanks a lot to all involved.

Signed-off-by: Felix Kronlage-Dammers <[email protected]>
@fkr fkr merged commit e3670f0 into main Dec 12, 2024
5 of 6 checks passed
@fkr fkr deleted the feat/add-scs-0005-project-governance branch December 12, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants