-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add scs 0005 project governance #813
Conversation
ac0b04f
to
a6cdbdd
Compare
This looks good to me, though it's not yet marked "Ready for review". |
4cf729b
to
cff3e8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
There is one todo left, that I will add later today:
|
There is one major hurdle that I've not solved yet (also posted to Matrix last week): We assumed that all egible voters are the people in the github org. However for those we do not have e-mail addesses and as such no easy way of reaching out to them and onboard them into the voting system (which requires e-mail). @garloff any chance we can somehow map the github members <-> Members of the UCS? |
We have no github handles stored in UCS. We currently have full names for all github users in github-manager, we could leverage the fact that we consistently used Firstname.Lastname on UCS. But this would fail for some cases:
I am checking whether the github API allows for access for public email addresses of users. |
37 out of 129 Org members have a public mail address set, 92 do not. NAMES=`grep login: data.yaml | sed 's/^[^l]*login: //'`
for name in $NAMES; do echo -n "$name: "; curl -sL -H "Accept: application/vnd.github+json" -H "Authorization: Bearer github_pat_REDACTED" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/users/$name | jq ".email" | tr -d '"'; done | tee mails |
This results in 71 UCS accounts where I expect most of which have functional mail addresses. FNAMES=`grep name: data.yaml | sed 's/^[^l]*name: //'`
while read first last; do echo -n "$first $last:"; grep username: udm.users | grep -i "$first\\.$last" || echo " null" ; done < <(echo "$FNAMES") > ucs.mails |
With some magic to replace umlauts ... I get to 87 UCS accounts with 42 missing. There's ~ a handful more that can be resolved manually. We could of course require voters to
SEDUML='s/ä/ae/g;s/ö/oe/g;s/ü/ue/g;s/ß/ss/g;s/é/e/g;s/ý/y/g;s/č/c/g;s/Ä/Ae/g;s/Ö/Oe/g;s/Ü/Ue/g'
while read first last; do if test "$first" = "Dr."; then first=${last%% *}; last=${last# *}; fi; fir=$(echo "$first" | sed "$SEDUML"); las=${last#* }; las=${las%% *}; las=$(echo $las | sed "$SEDUML"); echo -n "$first $last: "; grep username: udm.users | grep -i "$fir\\.$las" | sed 's/ *username: \(.*\)$/\[email protected]/'; if test ${PIPESTATUS[1]} != 0; then echo "null"; fi ; done < <(echo "$FNAMES") > ucs.mails |
I'm tempted to say we do it that way. |
thanks for your suggestions @garloff |
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Jan Schoone <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Jan Schoone <[email protected]>
Suggested by @michaelbayr Signed-off-by: Felix Kronlage-Dammers <[email protected]>
prompted by @michaelbayr Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Jan Schoone <[email protected]>
Signed-off-by: Jan Schoone <[email protected]>
requested by @michaelbayr Signed-off-by: Felix Kronlage-Dammers <[email protected]>
…community call Thanks to @michaelbayr, @berendt and others who actively participated. Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Co-authored-by: Kurt Garloff <[email protected]> Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Co-authored-by: Kurt Garloff <[email protected]> Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
4e19991
to
48e079c
Compare
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Co-authored-by: Kurt Garloff <[email protected]> Signed-off-by: Felix Kronlage-Dammers <[email protected]>
@michaelbayr - this looks good to me now and I believe your good questions and suggestions have all been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
Thanks for the excellent work, @fkr, @michaelbayr .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just a note on mapping the GitHub Org Roles to SCS Community Members and SCS Project Board Members, with a suggestion for L34-L37. The bullet points can also be removed to be less precise as they are just an idea but could lead to more discussion.
Co-authored-by: Max Wolfs <[email protected]> Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Awesome collaboration - thanks a lot to all involved. |
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
No description provided.