DEV_21 #6
Merged
DEV_21 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bra-fsn
approved these changes
Feb 22, 2024
| @@ -49,8 +50,15 @@ def __init__(subclass, *args, **kwargs): | |||
| comment = satable.columns[k].comment | |||
| if v.description and comment is None: | |||
| satable.columns[k].comment = v.description | |||
| # append inserted_at as last column | |||
| satable.append_column(Column("inserted_at", DateTime, default=datetime.utcnow)) | |||
| # append observed_at as last column | |||
There was a problem hiding this comment.
Will/are we get/ting the actual version of the DB before running this, or will this column always contain new values on every run?
There was a problem hiding this comment.
As the observed_at column is inserted at the SQLAlchemy level, SQLModel doesn't know about it (it's not a ~pydantic field), so if there's no change in the actual values of the row, the observed_at field will NOT be updated in the database via the session.merge calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws.pyinto helper/getter sections (sorry, this is a painful diff)