Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #12

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Develop #12

wants to merge 8 commits into from

Conversation

ImmoStanke
Copy link

I rewrote the get-auth-map function to use Google REST API (instead of Java interop) and added a new type for AuthMap, which is returned by that function now. This also converts the json returned by google with keys like "access_token" to a proper clojure map with the key :access-token, which is what is expected in GoogleCtx. I'm using HTTPkit to send the requests and clojure.data.json to parse the json response. HTTPkit can easily be replaced by whatever other library you'd prefer to send HTTP requests, but it works pretty well.
Furthermore, I added a function to refresh an existing google token, which also returns an AuthMap containing the new token.
Users can also specify their own redirect-url, instead of always using copy paste, this enables you to have google send the auth-code directly to your web app. Consequently, you may also now specify your access-type as "online" or "offline". Both values are read from the google-context, defaulting to the previous functionality if none are given.

PS: Sorry for the messy commits, I worked on the master branch and then merged to develop. If you want you can also merge the master branch directly.

@takeoutweight
Copy link
Contributor

Hey, this is an ridiculously late response but I want to thank you for putting together this very reasonable PR. We completely dropped the ball on maintaining this library; we're sorry for that and understand how annoying it is to get radio silence after putting work into a PR. We're currently undergoing a review of our open source policies w/ legal and, for what it's worth, should be able to respond to PRs on this project soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants