Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling query() twice by adding a local var, fixes #4133 and #4140 #4221

Open
wants to merge 5 commits into
base: 3.1
Choose a base branch
from
Open

Avoid calling query() twice by adding a local var, fixes #4133 and #4140 #4221

wants to merge 5 commits into from

Commits on Oct 16, 2024

  1. Avoid calling query() twice by adding a local var, fixes SpartnerNL#4133 

     and SpartnerNL#4140
    @Synchro
    Synchro committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3f32c4f View commit details
    Browse the repository at this point in the history

  2. Need a clone() here because chunk() appears to change the $query inst… 

    …ance
    @Synchro
    Synchro committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b57ce07 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @Synchro
    Synchro committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ea1fe6a View commit details
    Browse the repository at this point in the history

  4. Restore original chunk size

    @Synchro
    Synchro committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3bc628f View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Use clone operator directly to support old Laravel versions that lack… 

    … a clone method
    @Synchro
    Synchro committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f351554 View commit details
    Browse the repository at this point in the history