Move menuitem from list to tabs #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codeweld
changed the title
Codeweld
requested changes
Nov 18, 2024
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| /etc/build/* | |||
| !/etc/build/.gitignore | |||
| /.idea | |||
There was a problem hiding this comment.
This file should be specified in your global gitignore, not in the project's.
Please remove it
| speardevs_push_notifications_history_index: | ||
| path: /account/push-notifications-history | ||
| speardevs_push_notifications: | ||
| path: /account/push-notifications-section |
There was a problem hiding this comment.
/account/push-notifications?
| @@ -0,0 +1,37 @@ | |||
| {% extends '@SyliusShop/Account/RefundationDocument/layout.html.twig' %} | |||
There was a problem hiding this comment.
No, we shouldn't have a project-specific stuff in the plugin's codebase.
Please do the changes based on the default Sylius templates, to make it work correctly with the default Sylius.
If you need anything project-specific, then you need to extend or override templates directly in the project codebase.
But then you would need to make sure, that everything works correctly with the default Sylius
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.