BED-5022 Handle GetDatapipeStatus Errors #976
Draft
+92
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvlipka
added
bug
mvlipka
changed the title
mistahj67
reviewed
Nov 22, 2024
| @@ -165,8 +165,7 @@ type Database interface { | |||
| AnalysisRequestData | |||
|
|
|||
| // Datapipe Status | |||
| SetDatapipeStatus(ctx context.Context, status model.DatapipeStatus, updateAnalysisTime bool) error | |||
| GetDatapipeStatus(ctx context.Context) (model.DatapipeStatusWrapper, error) | |||
| DatapipeStatusData | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In certain environments, it was found that the
/api/v2/datapipe/statusendpoint was occasionally returning a 200 status, but without a response. TheGetDatapipeStatusdatabase call currently only checks for an error if no rows were returned, but does not catch all errors that can result from this query.Motivation and Context
This PR addresses: BED-5022
This change now allows all database errors to be bubbled up to the api and subsequently returned to the user so that we may monitor this issue more closely and narrow down potential problems.
How Has This Been Tested?
Additional unit tests were added to the
GetDatapipeStatusendpointScreenshots (optional):
Types of changes
Checklist: