add all missing deps to useEffect deps arrays

Spencer-Sch · Dec 1, 2023 · 7836ed7 · 7836ed7
1 parent d6337d5
commit 7836ed7
Show file tree

Hide file tree

Showing 13 changed files with 13 additions and 13 deletions.
diff --git a/packages/nextjs/components/dash-wind/containers/Layout.tsx b/packages/nextjs/components/dash-wind/containers/Layout.tsx
@@ -29,7 +29,7 @@ function Layout() {
       if (newNotificationStatus === 0) (NotificationManager as any).error(newNotificationMessage, "Error");
       dispatch(removeNotificationMessage());
     }
-  }, [newNotificationMessage]);
+  }, [dispatch, newNotificationMessage, newNotificationStatus]);
 
   return (
     <>

diff --git a/packages/nextjs/components/dash-wind/containers/SidebarSubmenu.tsx b/packages/nextjs/components/dash-wind/containers/SidebarSubmenu.tsx
@@ -29,7 +29,7 @@ function SidebarSubmenu({ submenu, name, icon, className }: SidebarSubmenuProps)
       })[0]
     )
       setIsExpanded(true);
-  }, []);
+  }, [router.pathname, submenu]);
 
   return (
     <div className="flex-col">

diff --git a/packages/nextjs/components/dash-wind/pages/protected/Bills.tsx b/packages/nextjs/components/dash-wind/pages/protected/Bills.tsx
@@ -8,7 +8,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "Bills" }));
-  }, []);
+  }, [dispatch]);
 
   return <Billing />;
 }

diff --git a/packages/nextjs/components/dash-wind/pages/protected/Blank.tsx b/packages/nextjs/components/dash-wind/pages/protected/Blank.tsx
@@ -8,7 +8,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "Page Title" }));
-  }, []);
+  }, [dispatch]);
 
   return (
     <div className="hero h-4/5 bg-base-200">

diff --git a/packages/nextjs/components/dash-wind/pages/protected/Calendar.tsx b/packages/nextjs/components/dash-wind/pages/protected/Calendar.tsx
@@ -8,7 +8,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "Calendar" }));
-  }, []);
+  }, [dispatch]);
 
   return <Calendar />;
 }

diff --git a/packages/nextjs/components/dash-wind/pages/protected/Charts.tsx b/packages/nextjs/components/dash-wind/pages/protected/Charts.tsx
@@ -8,7 +8,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "Analytics" }));
-  }, []);
+  }, [dispatch]);
 
   return <Charts />;
 }

diff --git a/packages/nextjs/components/dash-wind/pages/protected/Integration.tsx b/packages/nextjs/components/dash-wind/pages/protected/Integration.tsx
@@ -8,7 +8,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "Integrations" }));
-  }, []);
+  }, [dispatch]);
 
   return <Integration />;
 }

diff --git a/packages/nextjs/components/dash-wind/pages/protected/Leads.tsx b/packages/nextjs/components/dash-wind/pages/protected/Leads.tsx
@@ -8,7 +8,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "Leads" }));
-  }, []);
+  }, [dispatch]);
 
   return <Leads />;
 }

diff --git a/packages/nextjs/components/dash-wind/pages/protected/ProfileSettings.tsx b/packages/nextjs/components/dash-wind/pages/protected/ProfileSettings.tsx
@@ -8,7 +8,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "Settings" }));
-  }, []);
+  }, [dispatch]);
 
   return <ProfileSettings />;
 }

diff --git a/packages/nextjs/components/dash-wind/pages/protected/Team.tsx b/packages/nextjs/components/dash-wind/pages/protected/Team.tsx
@@ -8,7 +8,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "Team Members" }));
-  }, []);
+  }, [dispatch]);
 
   return <Team />;
 }

diff --git a/packages/nextjs/components/dash-wind/pages/protected/Transactions.tsx b/packages/nextjs/components/dash-wind/pages/protected/Transactions.tsx
@@ -8,7 +8,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "Transactions" }));
-  }, []);
+  }, [dispatch]);
 
   return <Transactions />;
 }

diff --git a/packages/nextjs/components/dash-wind/pages/protected/Welcome.tsx b/packages/nextjs/components/dash-wind/pages/protected/Welcome.tsx
@@ -9,7 +9,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "" }));
-  }, []);
+  }, [dispatch]);
 
   return (
     <div className="hero h-4/5 bg-base-200">

diff --git a/packages/nextjs/components/dash-wind/pages/protected/_404.tsx b/packages/nextjs/components/dash-wind/pages/protected/_404.tsx
@@ -8,7 +8,7 @@ function InternalPage() {
 
   useEffect(() => {
     dispatch(setPageTitle({ title: "" }));
-  }, []);
+  }, [dispatch]);
 
   return (
     <div className="hero h-4/5 bg-base-200">