-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Env var support in agent configs #89
base: feat/VDX-308
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the delimiter to ||, or better yet to ?? So that is it more natural to read.
Had a really quick look, but do the default values actually work?
|
The correlationIds map VCI option files onto VCI metadata and VP option files onto presentation_definitions files. So they need to be unique for a tuple of these files. For now a correlationId related to VCI does not affect VP or vice versa, so there can be overlap between these. However it is wise to just have a correlationId unique per ecosystem, which then is present in a single file for VCI options, VCI metadata, VP options and presentation_definition Current changes to correlationId do not ensure that. We can/should just use another identifier for the them, like for instance the ecosystem name |
5fa8b0a
to
81a005a
Compare
We do not need this now. Let's see in sprint review/start what to do with this |
No description provided.