Feature/sdk 39 well known oidf (SDK-44 also)

[sanderPostma]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.49%. Comparing base (11632c3) to head (addbde5).
Report is 28 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
- Coverage    48.50%   48.49%   -0.02%     
===========================================
  Files           75       75              
  Lines         5115     5114       -1     
  Branches      1735     1773      +38     
===========================================
- Hits          2481     2480       -1     
  Misses        2631     2631              
  Partials         3        3              

Flag	Coverage Δ
unittest	48.49% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[sanderPostma]

Also contains a fix for mdoc which i stumbled upon

[zoemaas]

LGTM

[TimoGlastra]

@sanderPostma curious why did you add this code to bypass PEX for mdocs? I recently added the missing pieces for mdoc in PEX (and we're using mdoc with PEX now).

// Handle mdocs, keep them out of pex
  let presentationsArray = (Array.isArray(presentations) ? presentations : [presentations])
  if (presentationsArray.every(p => p.format === 'mso_mdoc')) {
    return
  }  
  presentationsArray = presentationsArray.filter((p) => p.format !== 'mso_mdoc')

Is there something we now need to do manually on top of pex to make it work? Won't this make the PD validation fail if it contains mdoc input descriptors?

[sanderPostma]

I have been told PEX does not support mdoc a while ago, and because of this our code base has many places where we keep mdoc out of PEX.
In this instance the Funke mdoc PID crashed our Funke RP flow in validatePresentationAgainstDefinition / assertValidVerifiablePresentations.

[TimoGlastra]

Can you share the pd and cred? There's tests in PEX that cover the PID in mdoc format:

https://github.com/Sphereon-Opensource/PEX/blob/develop/test/Mdoc.spec.ts

Which version of PEX are you using?

I think the easiest approach is to use PEX for mdoc as well, as it removes the need for a lot of hacks/workarounds

cc @nklomp