Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/SPRIND-89 #177

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

feature/SPRIND-89 #177

wants to merge 22 commits into from

Conversation

BtencateSphereon
Copy link
Contributor

No description provided.

@Sphereon-Opensource Sphereon-Opensource deleted a comment from codecov bot Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 75.43860% with 42 lines in your changes missing coverage. Please review.

Project coverage is 48.95%. Comparing base (e33ead1) to head (1989813).
Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
packages/client/lib/OpenID4VCIClientV1_0_11.ts 57.89% 8 Missing ⚠️
...s/issuer/lib/builder/IssuerMetadataBuilderV1_13.ts 0.00% 6 Missing ⚠️
packages/client/lib/AuthorizationCodeClient.ts 82.75% 5 Missing ⚠️
packages/client/lib/OpenID4VCIClient.ts 80.76% 5 Missing ⚠️
packages/client/lib/MetadataClientV1_0_11.ts 50.00% 3 Missing ⚠️
packages/client/lib/MetadataClientV1_0_13.ts 50.00% 3 Missing ⚠️
packages/client/lib/OpenID4VCIClientV1_0_13.ts 84.21% 3 Missing ⚠️
.../lib/builder/AuthorizationServerMetadataBuilder.ts 0.00% 3 Missing ⚠️
packages/client/lib/MetadataClient.ts 66.66% 2 Missing ⚠️
packages/issuer-rest/lib/OID4VCIServer.ts 77.77% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #177      +/-   ##
===========================================
+ Coverage    48.49%   48.95%   +0.46%     
===========================================
  Files           75       75              
  Lines         5114     5319     +205     
  Branches      1735     1845     +110     
===========================================
+ Hits          2480     2604     +124     
- Misses        2631     2712      +81     
  Partials         3        3              
Flag Coverage Δ
unittest 48.95% <75.43%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BtencateSphereon BtencateSphereon marked this pull request as ready for review January 15, 2025 22:08
Copy link

@ronal2do ronal2do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I'm just missing unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants