Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: VDX-339 improve error handling definitionVersionDiscovery #175

Closed
wants to merge 2 commits into from

Conversation

sanderPostma
Copy link
Contributor

@sanderPostma sanderPostma commented Oct 25, 2024

I am not a fan of returning Record<string, unknown> as error type. You still can't see what's coming back.
I had types generated for ValidationError

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.06%. Comparing base (be27cde) to head (c235d89).

Files with missing lines Patch % Lines
lib/utils/VCUtils.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
+ Coverage    89.95%   90.06%   +0.11%     
===========================================
  Files           66       66              
  Lines         2718     2729      +11     
  Branches       705      711       +6     
===========================================
+ Hits          2445     2458      +13     
+ Misses         255      253       -2     
  Partials        18       18              
Flag Coverage Δ
unittest 90.06% <95.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanderPostma sanderPostma changed the title chore: improve error handling definitionVersionDiscovery chore: VDX-339 improve error handling definitionVersionDiscovery Oct 25, 2024
@sanderPostma sanderPostma deleted the feature/error-types branch October 25, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant