feat: implement azure keyvault rest client #56
Conversation
…_esim # Conflicts: # pnpm-lock.yaml
There was a problem hiding this comment.
Please change kms name handling with the empty strings. That will lead to errors. Rather ignore it with @ts-ignore. Then a regular Veramo KMS will throw an error and our KMS handles it nicely.
| @@ -23,7 +23,7 @@ export class JwkDIDProvider extends AbstractIdentifierProvider { | |||
| async createIdentifier(args: ICreateIdentifierArgs, context: IRequiredContext): Promise<Omit<IIdentifier, 'provider'>> { | |||
| const key = await importProvidedOrGeneratedKey( | |||
| { | |||
| kms: args.kms ?? this.defaultKms, | |||
| kms: args.kms ?? this.defaultKms ?? '', | |||
There was a problem hiding this comment.
Rather have a ts-ignore here. Our KMS handles it correctly when no KMS is provided. Using an empty string will result in errors
| @@ -67,7 +67,7 @@ export class SphereonKeyDidProvider extends AbstractIdentifierProvider { | |||
|
|
|||
| const key = await importProvidedOrGeneratedKey( | |||
| { | |||
| kms: kms ?? this.kms, | |||
| kms: kms ?? this.kms ?? '', | |||
There was a problem hiding this comment.
Rather have a ts-ignore here. Our KMS handles it correctly when no KMS is provided. Using an empty string will result in errors
| @@ -48,7 +48,7 @@ export class OydDIDProvider extends AbstractIdentifierProvider { | |||
| const keyType: OydDidSupportedKeyTypes = options?.keyType || 'Ed25519' | |||
| const key = await this.holdKeys( | |||
| { | |||
| kms: kms || this.defaultKms, | |||
| kms: kms || this.defaultKms || '', | |||
There was a problem hiding this comment.
Rather have a ts-ignore here. Our KMS handles it correctly when no KMS is provided. Using an empty string will result in errors
| @@ -102,7 +102,7 @@ export class OydDIDProvider extends AbstractIdentifierProvider { | |||
| private async holdKeys(args: OydDidHoldKeysArgs, context: IContext): Promise<IKey> { | |||
| if (args.options.privateKeyHex) { | |||
| return context.agent.keyManagerImport({ | |||
| kms: args.kms || this.defaultKms, | |||
| kms: args.kms || this.defaultKms || '', | |||
There was a problem hiding this comment.
Rather have a ts-ignore here. Our KMS handles it correctly when no KMS is provided. Using an empty string will result in errors
| @@ -113,7 +113,7 @@ export class OydDIDProvider extends AbstractIdentifierProvider { | |||
| } | |||
| return context.agent.keyManagerCreate({ | |||
| type: args.options.keyType, | |||
| kms: args.kms || this.defaultKms, | |||
| kms: args.kms || this.defaultKms || '', | |||
There was a problem hiding this comment.
Rather have a ts-ignore here. Our KMS handles it correctly when no KMS is provided. Using an empty string will result in errors
No description provided.