Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration of Packet 0xBE #1304

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Registration of Packet 0xBE #1304

merged 5 commits into from
Oct 14, 2024

Conversation

GladieUO
Copy link
Contributor

@GladieUO GladieUO commented Oct 10, 2024

Just definition or registration of packet to avoid console error of unknown packet. Not sure if its that easy.
I tested it and it dont show unknown packet error anymore. Is that something we can add?
#1303
https://docs.polserver.com/packets/index.php?Packet=0xBE

Just definition or registration of packet to avoid console error of unknown packet...
@cbnolok
Copy link
Contributor

cbnolok commented Oct 14, 2024

Could you fix that warning?
It means that you need to define the constructor in the cpp file, even by doing PacketAssistVersion::PacketAssistVersion : Packet(......................) = default;

@GladieUO
Copy link
Contributor Author

Could you fix that warning? It means that you need to define the constructor in the cpp file, even by doing PacketAssistVersion::PacketAssistVersion : Packet(......................) = default;

should be good now.

@cbnolok cbnolok merged commit f051889 into Sphereserver:dev Oct 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants