Fix field name generation and accept string identifier for filter entity #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gilles-g Can you review this pull request please ? |
gilles-g
reviewed
Jul 31, 2024
| @@ -86,7 +87,7 @@ public function filterEntity(GetFilterConditionEvent $event) | |||
|
|
|||
| if ($dqlFrom = $event->getQueryBuilder()->getDQLPart('from')) { | |||
| $rootPart = reset($dqlFrom); | |||
| $fieldName = ltrim($event->getField(), $rootPart->getAlias() . '.'); | |||
| $fieldName = \str_replace(\sprintf('%s.', $rootPart->getAlias()), null, $event->getField()); | |||
There was a problem hiding this comment.
str_replace works better than ltrim in some case?
There was a problem hiding this comment.
Using ltrim method is not correct here. ltrim replace all listing characters and not word.
Example, 2 entities :
- Document with alias document
- Category with alias category
dump($event->getField()); // document.category
dump($rootPart->getAlias() . '.'); // document.
// Before (wrong)
dump(ltrim($event->getField(), $rootPart->getAlias() . '.')); // ategory
// After (good)
dump(\str_replace(\sprintf('%s.', $rootPart->getAlias()), null, $event->getField())); // category
|
Thx @alioguz |
gilles-g
pushed a commit
that referenced
this pull request
Jul 31, 2024
…ity (#21) Co-authored-by: Ali OGUZ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.