Fix date time range filter data extraction #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gilles-g could you or someone else have a look at this, please? It would be important for us to get this merged ASAP. Thanks! |
gilles-g
reviewed
Jul 3, 2024
| @@ -53,9 +53,6 @@ public function extract(FormInterface $form) | |||
| $values['value'][$key][$k] = $v; | |||
| } | |||
| } | |||
| } else { | |||
| dump($keys, $data); | |||
| throw new \InvalidArgumentException(sprintf('No value found for key "%s" in form data.', $key)); | |||
There was a problem hiding this comment.
You have removed the exception, I'm not sure about this
There was a problem hiding this comment.
Yes, because calling
$this->filterUpdater->addFilterConditions($filter, $filterBuilder);
will throw if we do not provide all the date filters. I think filters are optional and should not throw an exception if one is missing. All the other extraction method have the same behavior and it is not part of the contract either.
|
Thx @1ed |
|
Great! Thank you very much! |
gilles-g
pushed a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.