Bug Fix: Should not remove the predefined inline styles of slides.

Splidejs · Oct 9, 2021 · b3a127b · b3a127b
1 parent da6cf79
commit b3a127b
Show file tree

Hide file tree

Showing 11 changed files with 23 additions and 16 deletions.
diff --git a/dist/js/splide-renderer.min.js b/dist/js/splide-renderer.min.js
diff --git a/dist/js/splide.cjs.js b/dist/js/splide.cjs.js
@@ -1,6 +1,6 @@
 /*!
  * Splide.js
- * Version  : 3.1.1
+ * Version  : 3.1.2
  * License  : MIT
  * Copyright: 2021 Naotoshi Fujita
  */
@@ -1020,7 +1020,7 @@ function Layout(Splide2, Components2, options) {
     emit(EVENT_RESIZED);
   }
   function setSlidesHeight() {
-    Slides.style("height", cssSlideHeight(), true);
+    Slides.style("height", cssSlideHeight() || null, true);
   }
   function cssPadding(right) {
     const { padding } = options;

diff --git a/dist/js/splide.esm.js b/dist/js/splide.esm.js
@@ -1,6 +1,6 @@
 /*!
  * Splide.js
- * Version  : 3.1.1
+ * Version  : 3.1.2
  * License  : MIT
  * Copyright: 2021 Naotoshi Fujita
  */
@@ -1016,7 +1016,7 @@ function Layout(Splide2, Components2, options) {
     emit(EVENT_RESIZED);
   }
   function setSlidesHeight() {
-    Slides.style("height", cssSlideHeight(), true);
+    Slides.style("height", cssSlideHeight() || null, true);
   }
   function cssPadding(right) {
     const { padding } = options;

diff --git a/dist/js/splide.js b/dist/js/splide.js
diff --git a/dist/js/splide.js.map b/dist/js/splide.js.map
diff --git a/dist/js/splide.min.js b/dist/js/splide.min.js
diff --git a/dist/js/splide.min.js.gz b/dist/js/splide.min.js.gz
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@splidejs/splide",
-  "version": "3.1.1",
+  "version": "3.1.2",
   "description": "Splide is a lightweight, flexible and accessible slider/carousel. No dependencies, no Lighthouse errors.",
   "author": "Naotoshi Fujita",
   "license": "MIT",

diff --git a/src/js/components/Drag/test/general.test.ts b/src/js/components/Drag/test/general.test.ts
@@ -9,7 +9,7 @@ describe( 'Drag', () => {
     const track  = splide.Components.Elements.track;
 
     fireWithCoord( track, 'mousedown', { x: 0, timeStamp: 1 } );
-    fireWithCoord( window, 'mousemove', { x: 0, timeStamp: 1 } );
+    fireWithCoord( window, 'mousemove', { x: 1, timeStamp: 1 } );
     fireWithCoord( window, 'mousemove', { x: -100, timeStamp: 2 } );
 
     expect( splide.Components.Move.getPosition() ).toBe( -100 );
@@ -24,7 +24,7 @@ describe( 'Drag', () => {
     const track  = splide.Components.Elements.track;
 
     fireWithCoord( track, 'mousedown', { x: 0 } );
-    fireWithCoord( window, 'mousemove', { x: 0 } );
+    fireWithCoord( window, 'mousemove', { x: 1 } );
     fireWithCoord( window, 'mouseup' );
 
     expect( splide.Components.Move.getPosition() ).toBe( 0 );
@@ -40,7 +40,7 @@ describe( 'Drag', () => {
     const track  = splide.Components.Elements.track;
 
     fireWithCoord( track, 'mousedown', { x: 0, timeStamp: 1 } );
-    fireWithCoord( window, 'mousemove', { x: 0, timeStamp: 1 } );
+    fireWithCoord( window, 'mousemove', { x: 1, timeStamp: 1 } );
     fireWithCoord( window, 'mousemove', { x: -20, timeStamp: 21 } ); // v = -1
     fireWithCoord( window, 'mouseup',   { x: -20, timeStamp: 21 } );
 
@@ -53,7 +53,7 @@ describe( 'Drag', () => {
     const track  = splide.Components.Elements.track;
 
     fireWithCoord( track, 'mousedown', { x: 0, timeStamp: 1 } );
-    fireWithCoord( window, 'mousemove', { x: 0, timeStamp: 1 } );
+    fireWithCoord( window, 'mousemove', { x: 1, timeStamp: 1 } );
     fireWithCoord( window, 'mousemove', { x: -20, timeStamp: 100 } );
     fireWithCoord( window, 'mouseup',   { x: -20, timeStamp: 100 } );
 

diff --git a/src/js/components/Layout/Layout.ts b/src/js/components/Layout/Layout.ts
@@ -83,7 +83,7 @@ export function Layout( Splide: Splide, Components: Components, options: Options
    * Updates the height of slides or their container elements if available.
    */
   function setSlidesHeight(): void {
-    Slides.style( 'height', cssSlideHeight(), true );
+    Slides.style( 'height', cssSlideHeight() || null, true );
   }
 
   /**

diff --git a/src/js/test/php/examples/autoHeight.php b/src/js/test/php/examples/autoHeight.php
@@ -23,11 +23,18 @@
         autoHeight: true,
         gap       : '1rem',
         trimSpace : 'move',
+        focus     : 'center',
       } );
 
       splide.mount();
     } );
   </script>
+
+  <style>
+    .splide__slide {
+      overflow: hidden;
+    }
+  </style>
 </head>
 <body>