Add an encoder and bump to PHP8.2 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor tests and implementation to use integers for normalization instead of strings, including Unsigned and Signed Integer Tests and associated data providers. Migrate dependencies in composer.json and update various configurations for PHP 8.2 syntax support and PHPUnit 11.0.
Refactored encode and process methods for clarity in Encoder.php. Simplified TagManager and OtherObjectManager by using constructors and arrays. Improved string conversion logic in several CBOR classes. Optimized vector tests to reduce complexity. Removed redundant PHPStan baseline errors and updated ECS configuration for precise directory paths.
Removed the unused `PhpUnitTestClassRequiresCoversFixer` import from `ecs.php`. Enhanced the Rector configuration in `rector.php` by adding Symfony sets for code quality, constructor injection, and validator attributes, while keeping imports organized and removing unused imports.
Deleted the Makefile and incorporated related CI tasks into GitHub workflows. Updated the workflows to use Castor for tasks previously handled by make commands. Added new workflows for dependency review, issue locking, and scorecards analysis. Adjusted phpstan baseline and deptrac configurations accordingly.
Integrated the Castor tool into various jobs in the GitHub Actions workflow file. This enhances the linting process and ensures compatibility across multiple PHP versions defined in the CI configuration. Updated commands to utilize Castor for improved syntax checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch: 4.0.x