Skip to content

Commit

Permalink
Update CI workflow to use Castor and simplify commands
Browse files Browse the repository at this point in the history
Replaced 'make' commands in the CI workflow with 'castor' commands for better consistency and maintainability. Removed redundant 'install' and 'compile assets' steps and adjusted service reachability checks to point to default ports. Minor cleanup in `frontend` function call in `castor.php`.
  • Loading branch information
Spomky committed Jan 28, 2025
1 parent 89e36e7 commit 927e33e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
12 changes: 4 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ jobs:
- name: Check security
uses: symfonycorp/security-checker-action@v2
- name: Pull images
run: make build
run: castor build
- name: Start services
run: make up
run: castor start
- name: Wait for services
run: |
while status="$(docker inspect --format="{{if .Config.Healthcheck}}{{print .State.Health.Status}}{{end}}" "$(docker compose ps -q php)")"; do
Expand All @@ -44,11 +44,7 @@ jobs:
esac
done
exit 1
- name: Install dependencies
run: make install
- name: Compile assets
run: make assets
- name: Check HTTP reachability
run: curl http://localhost:8080
run: curl http://localhost
- name: Check HTTPS reachability
run: curl -k https://localhost:8443
run: curl -k https://localhost
2 changes: 1 addition & 1 deletion castor.php
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ function start(string $xdebugMode = 'develop', bool $fixtures = false): void
if ($fixtures) {
console(['doctrine:fixtures:load', '--no-interaction']);
}
frontend(true);
frontend();
}

#[AsTask(description: 'Build the images.')]
Expand Down

0 comments on commit 927e33e

Please sign in to comment.