Merge up 1.1.3 to 1.2.x #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove ImportMapConfigReader dependency from PwaRuntime The dependency on ImportMapConfigReader has been removed from PwaRuntime code to simplify Workbox URL generation. The URL is now directly derived from the `workboxPublicUrl` property of the serviceWorker's workbox object. This makes the code more maintainable and easy to read. * Remove ImportMapConfigReader dependency from PwaRuntime The ImportMapConfigReader dependency was removed from PwaRuntime.php, thus simplifying the Workbox URL generation process. The URL is now directly derived, resulting in a cleaner, more readable and easily maintainable codebase.
The arguments maxEntries and maxAgeInSeconds in the ExpirationPlugin::create() function have been swapped. This change fixes the data misalignment which was causing issues with data retention in the GoogleFontCache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.