Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new PWA controllers and refactor existing ones #234

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Spomky
Copy link
Member

@Spomky Spomky commented Sep 15, 2024

Target branch: 1.3.x
Resolves issue #

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

Introduced new controllers for

  • badge,
  • battery,
  • device-orientation,
  • fullscreen,
  • geolocation,
  • vibration
  • presentation/receiver

Refactored multiple controllers to extend from a base abstract controller for consistent event dispatching. Updated package.json to include these new controllers with proper webpack configurations.

@Spomky Spomky added the enhancement New feature or request label Sep 15, 2024
@Spomky Spomky added this to the 1.3.0 milestone Sep 15, 2024
@Spomky Spomky self-assigned this Sep 15, 2024
@tacman
Copy link
Contributor

tacman commented Sep 15, 2024

Very cool! On a related note, what do you think of using the traditional Symfony routing (adding a /config/routing/pwa.yaml file) instead of injecting the routing? Mostly because it's non-standard to add a Symfony bundle's routes to an application. It's a bit of a pain, because without a recipe, it's another step.

@tacman
Copy link
Contributor

tacman commented Sep 15, 2024

Oops, these are javascript controllers, not Symfony controllers, so I should move that to a new issue.

@Spomky
Copy link
Member Author

Spomky commented Sep 15, 2024

On a related note, what do you think of using the traditional Symfony routing

Not sure to clearly understand. The bundle uses the Symfony Router to generate routes so that you can use absolute/relative paths or named routes.
As the bundle itself has no controller, no /config/routing/*.yaml is needed.

Introduced multiple new Stimulus controllers for handling various browser features such as battery, device orientation, geolocation, and more. Converted environment handling in `castor.php` to use context-based approach, ensuring better isolation and maintainability.
@Spomky
Copy link
Member Author

Spomky commented Oct 2, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Oct 2, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 6a3aa6a

@Spomky
Copy link
Member Author

Spomky commented Oct 2, 2024

@mergify update

Copy link
Contributor

mergify bot commented Oct 2, 2024

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • queue-position = -1 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mergify mergify bot merged commit 6a3aa6a into 1.3.x Oct 2, 2024
12 checks passed
@mergify mergify bot deleted the features/more-apis branch October 2, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants