Merge up 1.2.7 to 1.3.x #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods' return types have been updated from iterable<Data> to iterable<string, Data> in several files, namely FaviconsCompiler.php, ManifestCompiler.php, FileCompilerInterface.php, and ServiceWorkerCompiler.php. Moreover, yield statements have been modified to yield a pair of string (URL) and Data instead of just Data to enhance data identification and access.
) * Replace TaggedIterator with AutowireIterator across multiple files The commit switches the usage from TaggedIterator to AutowireIterator to better manage dependencies within the application. This affects multiple classes in src directory involving spomky_labs_pwa cache strategy, match callback handlers, and other related dependencies. The change enhances dependency handling and supports cleaner code injection.
* Refactor normalization methods for consistency and clarity. Updated method parameter names from `$object` to `$data` across multiple normalizers to align with coding standards. Improved nullable type hints and applied minor cleanups for better readability and maintainability. * Update dependencies and clean up PHPStan baseline Add support for newer versions of development dependencies in `composer.json` by updating version constraints. Remove resolved deprecation issues from the PHPStan baseline to maintain a cleaner codebase. * Update test assertions and refine PHPStan configurations Updated file path assertions in `CompileCommandTest` to align with new screenshot file naming conventions. Enhanced PHPStan configuration by adding banned code settings, adjusting indentation, and significantly expanding the baseline for ignored errors. * Refactor CompileCommandTest and update PHPStan configurations Remove redundant assertions in CompileCommandTest for improved clarity and tweak PHPStan to allow ignorable banned code. Added new rules to PHPStan baseline for managing specific edge cases in code analysis.
Replaced instances of `$object` with `$data` in the normalize method to match the method's parameter declaration. Ensures consistency and correct type handling during normalization.
Included NelmioSecurityBundle in composer dependencies to enhance security features. Simplified import management in PwaRuntime and improved code readability in PwaDevServerSubscriber by adjusting line formatting. These changes aim to improve maintainability and clarity.
Obsolete error entries were removed from the PHPStan baseline file, and counts for some existing errors were updated to reflect current analysis results. This streamlines static analysis and reduces unnecessary suppressions in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch:
Resolves issue #