Remove placeholders

ecs.php

@@ -28,7 +28,7 @@
 use PhpCsFixer\Fixer\Whitespace\ArrayIndentationFixer;
 use PhpCsFixer\Fixer\Whitespace\CompactNullableTypehintFixer;
 use PhpCsFixer\Fixer\Whitespace\MethodChainingIndentationFixer;
-use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer;
+use Symplify\CodingStandard\Fixer\Spacing\MethodChainingNewlineFixer;
 use Symplify\EasyCodingStandard\Config\ECSConfig;
 use Symplify\EasyCodingStandard\ValueObject\Set\SetList;
 
@@ -92,13 +92,10 @@
 
     $config->skip([
         PhpUnitTestClassRequiresCoversFixer::class,
-        MethodChainingIndentationFixer::class => [__DIR__.'/src/DependencyInjection/Configuration.php'],
-        \Symplify\CodingStandard\Fixer\Spacing\MethodChainingNewlineFixer::class => [__DIR__.'/src/DependencyInjection/Configuration.php'],
+        MethodChainingIndentationFixer::class => [__DIR__ . '/src/DependencyInjection/Configuration.php'],
+        MethodChainingNewlineFixer::class => [__DIR__ . '/src/DependencyInjection/Configuration.php'],
     ]);
 
     $config->parallel();
-    $config->paths([
-        __DIR__.'/src',
-        __DIR__.'/tests',
-    ]);
+    $config->paths([__DIR__ . '/src', __DIR__ . '/tests', __DIR__ . '/ecs.php', __DIR__ . '/rector.php']);
 };

phpstan-baseline.neon

@@ -320,6 +320,11 @@ parameters:
 			count: 1
 			path: src/Dto/Widget.php
 
+		-
+			message: "#^Attribute class JetBrains\\\\PhpStorm\\\\Deprecated does not exist\\.$#"
+			count: 4
+			path: src/Dto/Workbox.php
+
 		-
 			message: "#^Class SpomkyLabs\\\\PwaBundle\\\\Dto\\\\Workbox has an uninitialized property \\$enabled\\. Give it default value or assign it in the constructor\\.$#"
 			count: 1
@@ -468,4 +473,9 @@ parameters:
 		-
 			message: "#^Method SpomkyLabs\\\\PwaBundle\\\\Normalizer\\\\UrlNormalizer\\:\\:supportsNormalization\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#"
 			count: 1
-			path: src/Normalizer/UrlNormalizer.php
+			path: src/Normalizer/UrlNormalizer.php
+
+		-
+			message: "#^Property SpomkyLabs\\\\PwaBundle\\\\Service\\\\ServiceWorkerCompiler\\:\\:\\$jsonOptions type has no value type specified in iterable type array\\.$#"
+			count: 1
+			path: src/Service/ServiceWorkerCompiler.php

rector.php

@@ -25,10 +25,8 @@
         PHPUnitSetList::ANNOTATIONS_TO_ATTRIBUTES,
     ]);
     $config->phpVersion(PhpVersion::PHP_82);
-    $config->paths([__DIR__ . '/src', __DIR__ . '/tests']);
-    $config->skip([
-        __DIR__ . '/tests/Controller/DummyController.php',
-    ]);
+    $config->paths([__DIR__ . '/src', __DIR__ . '/tests', __DIR__ . '/ecs.php', __DIR__ . '/rector.php']);
+    $config->skip([__DIR__ . '/tests/Controller/DummyController.php']);
     $config->parallel();
     $config->importNames();
     $config->importShortClasses();

src/DependencyInjection/Configuration.php

@@ -126,25 +126,45 @@ private function setupServiceWorker(ArrayNodeDefinition $node): void
                                 ->info('The public path to the local workbox. Only used if use_cdn is false.')
                             ->end()
                             ->scalarNode('workbox_import_placeholder')
+                                ->setDeprecated(
+                                    'spomky-labs/phpwa',
+                                    '1.1.0',
+                                    'The "%node%" option is deprecated and will be removed in 2.0.0. No replacement.'
+                                )
                                 ->defaultValue('//WORKBOX_IMPORT_PLACEHOLDER')
                                ->info(
                                    'The placeholder for the workbox import. Will be replaced by the workbox import.'
                                )
                                 ->example('//WORKBOX_IMPORT_PLACEHOLDER')
                             ->end()
                             ->scalarNode('standard_rules_placeholder')
+                                ->setDeprecated(
+                                    'spomky-labs/phpwa',
+                                    '1.1.0',
+                                    'The "%node%" option is deprecated and will be removed in 2.0.0. No replacement.'
+                                )
                                 ->defaultValue('//STANDARD_RULES_PLACEHOLDER')
                                 ->info(
                                     'The placeholder for the standard rules. Will be replaced by caching strategies.'
                                 )
                                 ->example('//STANDARD_RULES_PLACEHOLDER')
                             ->end()
                             ->scalarNode('offline_fallback_placeholder')
+                                ->setDeprecated(
+                                    'spomky-labs/phpwa',
+                                    '1.1.0',
+                                    'The "%node%" option is deprecated and will be removed in 2.0.0. No replacement.'
+                                )
                                 ->defaultValue('//OFFLINE_FALLBACK_PLACEHOLDER')
                                 ->info('The placeholder for the offline fallback. Will be replaced by the URL.')
                                 ->example('//OFFLINE_FALLBACK_PLACEHOLDER')
                             ->end()
                             ->scalarNode('widgets_placeholder')
+                                ->setDeprecated(
+                                    'spomky-labs/phpwa',
+                                    '1.1.0',
+                                    'The "%node%" option is deprecated and will be removed in 2.0.0. No replacement.'
+                                )
                                 ->defaultValue('//WIDGETS_PLACEHOLDER')
                                 ->info(
                                     'The placeholder for the widgets. Will be replaced by the widgets management events.'

src/Dto/Workbox.php

@@ -4,6 +4,7 @@
 
 namespace SpomkyLabs\PwaBundle\Dto;
 
+use JetBrains\PhpStorm\Deprecated;
 use Symfony\Component\Serializer\Attribute\SerializedName;
 
 final class Workbox
@@ -19,15 +20,19 @@ final class Workbox
     public string $workboxPublicUrl;
 
     #[SerializedName('workbox_import_placeholder')]
+    #[Deprecated('No longer used.')]
     public string $workboxImportPlaceholder;
 
     #[SerializedName('standard_rules_placeholder')]
+    #[Deprecated('No longer used.')]
     public string $standardRulesPlaceholder;
 
     #[SerializedName('offline_fallback_placeholder')]
+    #[Deprecated('No longer used.')]
     public string $offlineFallbackPlaceholder;
 
     #[SerializedName('widgets_placeholder')]
+    #[Deprecated('No longer used.')]
     public string $widgetsPlaceholder;
 
     #[SerializedName('page_fallback')]

src/Resources/sw-skeleton.js

@@ -1,5 +1,6 @@
-// *** Workbox Bundle rules ***
-//WORKBOX_IMPORT_PLACEHOLDER
-//STANDARD_RULES_PLACEHOLDER
-//OFFLINE_FALLBACK_PLACEHOLDER
-//WIDGETS_PLACEHOLDER
+// *** Service Worker *** //
+/*
+    This is the service worker file. It will be populated with the rules you define in the
+    configuration file.
+    You can define here custom rules depending on your application needs.
+ */