Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of RawDataChannel during EngineConnectionState.Intent #4135

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

aromaa
Copy link
Member

@aromaa aromaa commented Oct 5, 2024

In proxied environment its sometimes useful to allow the communication between the proxy and the backend server before any authentication has begun. For example the proxy can be used to some degree as "source of truth" where it can provide information for sync points, capabilities and other relevant information that plugins might want to process before the ServerSideConnectionEvent.Auth begin.

While intercommunication trough messaging services should be preferred, sometimes the delay can cause race conditions and the proxy could be used to retrieve the more relevant up to date information on such cases.

This PR allows the following capability by allowing plugin developers to use the RawDataChannel during ServerSideConnectionEvent.Intent and delays the authentication process until no more requests are in-flight. By restricting this to only raw data channels, we can fill this niche use case without more evasive changes to the login process.

Open question:

  • Do we want to model this more explicitly in the API? Or update the documentation and call it a day.

@aromaa aromaa merged commit d4f1345 into api-12 Oct 12, 2024
8 checks passed
@aromaa aromaa deleted the api12/intent branch October 12, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant