Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct 'ifSucessful' to DataTransactionResult#ifSuccessful #1565

Closed
wants to merge 1 commit into from
Closed

Correct 'ifSucessful' to DataTransactionResult#ifSuccessful #1565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/spongepowered/api/data/DataTransactionResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ public List<ImmutableValue<?>> getReplacedData() {
*
* @param consumer The consumer to call
*/
public void ifSucessful(Consumer<List<ImmutableValue<?>>> consumer) {
Copy link
Contributor

@dualspiral dualspiral May 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should be deprecated (with a @deprecated tag explaining why in the javadocs), rather than outright removed, and call the correct method - a bit like what was done here. We'd then remove it two API versions up the road (so, if it was pulled now, we would want to deprecate for API 7, which we'd then remove in API 8)

public void ifSuccessful(Consumer<List<ImmutableValue<?>>> consumer) {
if (isSuccessful()) {
try {
consumer.accept(this.success);
Expand Down