Worked on email templete #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalvats
reviewed
Jun 10, 2021
kunalvats
reviewed
Jun 11, 2021
utils/transporter.js
Outdated
| const transporter = nodemailer.createTransport({ | ||
| service: "gmail", | ||
| auth: { | ||
| user: "[email protected]", |
There was a problem hiding this comment.
Better to use any credentials used in config files or default.json. Can be used at multiple places and will have to update at one place only, if needed.
kunalvats
reviewed
Jun 11, 2021
| `, | ||
| }; | ||
|
|
||
| try { |
There was a problem hiding this comment.
Should try-catch the whole function, and return the error. Anything could fail not just the mail.
kunalvats
reviewed
Jun 11, 2021
app.js
Outdated
| @@ -4,11 +4,12 @@ const cors = require("cors"); | |||
| const bcryptjs = require("bcryptjs"); | |||
| require("dotenv").config(); | |||
| require("./db/connectionDB"); | |||
| require('./models/user') | |||
| require('./models/Survey') | |||
There was a problem hiding this comment.
Should be /survey. Filename case should match always.
kunalvats
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.