Add NCP to S18 rounds query #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrFrankinStein
commented
Mar 2, 2025
DrFrankinStein
commented
- Check if the invalidation id is filled. Meaning a NCP.
- Stats line are now LEFT JOIN instead of INNER JOIN, meaning rounds without stats like NCP from a serie will still be there.
- IF NCP, clear the home/away goal count to 0.
- Because NCP makes goals to 0, added an explicit winner column.
- Query now returns ordered by match ID then round ID.
- Renamed columns
- Added comments for future reference
|
As discussed with @Mitchel-Berg, NCP check will not work right now due to another bug elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.