🐛 Always delcare tag symbols as references (#1648)

SpyglassMC · Nov 22, 2024 · 2de5efc · 2de5efc
1 parent bbc5f27
commit 2de5efc
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/core/src/service/Config.ts b/packages/core/src/service/Config.ts
@@ -425,6 +425,10 @@ export const VanillaConfig: Config = {
 				],
 				then: { report: 'warning' },
 			},
+			{
+				if: { category: ['attribute_modifier', 'attribute_modifier_uuid', 'tag'] },
+				then: { declare: 'public' },
+			},
 			{
 				then: { declare: 'block' },
 			},

diff --git a/packages/java-edition/src/mcfunction/mcdocAttributes.ts b/packages/java-edition/src/mcfunction/mcdocAttributes.ts
@@ -93,7 +93,7 @@ export function registerMcdocAttributes(meta: core.MetaRegistry, rootTreeNode: m
 		stringMocker: (_, __, ctx) => ScoreHolderNode.mock(ctx.offset),
 	})
 	mcdoc.runtime.registerAttribute(meta, 'tag', () => undefined, {
-		stringParser: () => parser.tag('definition'), // TODO: make this a config
+		stringParser: () => parser.tag('reference'),
 		stringMocker: (_, __, ctx) => core.SymbolNode.mock(ctx.offset, { category: 'tag' }),
 	})
 	mcdoc.runtime.registerAttribute(meta, 'block_predicate', () => undefined, {

diff --git a/packages/java-edition/src/mcfunction/tree/patch.ts b/packages/java-edition/src/mcfunction/tree/patch.ts
@@ -644,9 +644,6 @@ export function getPatch(release: ReleaseVersion): PartialRootTreeNode {
 								children: {
 									name: {
 										parser: 'spyglassmc:tag',
-										properties: {
-											usageType: 'definition',
-										},
 									},
 								},
 							},