Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support testing multiple versions in argument parser tests #1215

Closed
Calverin opened this issue May 29, 2024 · 1 comment · Fixed by #1216
Closed

Support testing multiple versions in argument parser tests #1215

Calverin opened this issue May 29, 2024 · 1 comment · Fixed by #1216
Assignees
@TheAfroOfDoom
Labels
/java-edition ♻ refactor Refactor code ✅ test
Milestone
Backlog

Comments

@Calverin
Copy link
Contributor

Should be set to 1.21 and generated test snapshots should be updated, requires changes to mockProjectData in packages/core/test/utils.ts
@Calverin Calverin added 🐛 bug Something isn't working ✅ test labels May 29, 2024
@misode
Copy link
Member

misode commented May 29, 2024

The 1.15 version was added as part of #1179 (c898160). See also my comment on #1202:

I looked at the tests for a bit but I didn't see a good way to test these parsers in multiple versions. Right now mockProjectData is hardcoded to 1.15. This might be something to do in a later PR.

@misode misode added this to the Backlog milestone May 29, 2024
@TheAfroOfDoom TheAfroOfDoom self-assigned this May 30, 2024
@misode misode changed the title Make Unit Tests use the latest version rather than 1.15 Support testing multiple versions in argument parser tests May 30, 2024
@TheAfroOfDoom TheAfroOfDoom added /java-edition ♻ refactor Refactor code and removed 🐛 bug Something isn't working labels May 30, 2024
@TheAfroOfDoom TheAfroOfDoom mentioned this issue May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheAfroOfDoom TheAfroOfDoom

Labels
/java-edition ♻ refactor Refactor code ✅ test
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

♻️ Enable specifying version in argument parser test cases TheAfroOfDoom/Spyglass
3 participants
@TheAfroOfDoom @misode @Calverin