♻️ Enable specifying version in argument parser test cases #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tests don't include version in name if it's `1.15` (default) to minimize diffs here
misode
reviewed
May 30, 2024
TheAfroOfDoom
commented
May 30, 2024
MulverineX
approved these changes
May 30, 2024
SPGoding
approved these changes
May 30, 2024
misode
approved these changes
May 31, 2024
TheAfroOfDoom
changed the title
Calverin
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1215
really just refactoring. there was a mistake where we were only passing in the
metaproperty to theprojectwhen runningtestParser. passing in the wholeprojectobject allowed us to also pass-in the desiredloadedVersionhttps://github.com/TheAfroOfDoom/Spyglass/blob/6103be7f90eb5583997ae14e28c807e156e63b3e/packages/java-edition/test/mcfunction/parser/argument.spec.ts#L323-L328
I also added some tests for the
1.20.5+particle parser. not sure if the snapshots look as expected? leaving that to you @misodei feel like i'm expecting them to raise some errors or something, but not seeing any..
here's some visuals
1.151.20.6