🐛 Fix JSON array/object parsers not absorbing child parser errors #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MulverineX
approved these changes
May 13, 2024
TheAfroOfDoom
force-pushed
the
fix-string-error-not-displaying
branch
from
370c273 to
74a6855
Compare
SPGoding
reviewed
May 14, 2024
TheAfroOfDoom
commented
May 14, 2024
misode
reviewed
May 14, 2024
TheAfroOfDoom
force-pushed
the
fix-string-error-not-displaying
branch
from
5bffcff to
41b5c8b
Compare
SPGoding
approved these changes
May 14, 2024
- covers generic cases, not the bug yet
- they aren't outputting errors as they should - for invalid char escape (`\z`) - for invalid unicode escape (`\u1z34`)
- giving `entry` as the `value` parser made it dump errors early (to a dummy `ctx`), before we absorbed them to a parent parser
- covers generic cases, not the bug yet - same as the array stuff earlier...
- only not working when the error is in the `value`; the `key` is fine - this makes sense when you see that `key`/`value` use different parsers
TheAfroOfDoom
force-pushed
the
fix-string-error-not-displaying
branch
from
41b5c8b to
f3258fe
Compare
misode
approved these changes
May 15, 2024
There was a problem hiding this comment.
I made some changes in order to make the json entry parser not take a boolean. Instead the error dumping is now handled by a separate wrapper, to make the intent more clear in the JSON initialize function and also so we don't accidentally dump errors in the future.
TheAfroOfDoom
commented
May 15, 2024
misode
reviewed
May 16, 2024
misode
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
these parsers were not absorbing their child parser's errors due to them calling the JSON
entryparser (json(dumpErrors = true))with
dumpErrors = true, the child parsers would dump errors into a temporary context that wasn't actually then sent to the language serverhttps://github.com/TheAfroOfDoom/Spyglass/blob/b6ecdcad78be7a44ef564afdfc9c51daedf38de8/packages/json/src/parser/entry.ts#L40-L42
fix is to not use the
entryparser and instead usejson(dumpErrors = false)so the errors from child parsers are absorbed later by the parent parsers and ultimately outputted to the language serverhttps://github.com/TheAfroOfDoom/Spyglass/blob/b6ecdcad78be7a44ef564afdfc9c51daedf38de8/packages/core/src/parser/util.ts#L67-L70
the JSON
arrayandobjectparsers were the only two places i found that were incorrectly using theentryparserScreenshots
JSON
arrayparserJSON
objectparserBlockers
this PR likely should wait until #1127 is merged since that PR fixes a related bug(the branch is currently rebased off of #1127, so those commits will show up here)#1127 has been merged, so no more blockers 😄