🔨 Better type for numeric mcdoc literals

[NeunEinser]

This makes numeric literal types more expressive in their type.

This makes checking these types against nodes a bit less cumbersome in my current related work.

[NeunEinser]

Looks like there is a failing test now, because of the node type change. I'll wait until I have feedback if this is a desirable change until looking into how to fix those.

[SPGoding]

Overall I think this would be a good change.

[NeunEinser]

I can't figure out how to fix the tests. From the output it looks like it tries to see if the current mcdoc exports are equivalent to what this branch would generate, but there is ofc an intentional mismatch. Not sure how to change the test data.

[SPGoding]

You can set the environment variable SNAPSHOT_UPDATE=1 when running npm test or just delete the __snapshots__ folder and let npm test re-generate that. We should probably add this to README

[NeunEinser]

It didn't re-generate __snapshots__/packages/core/test-out/service/Operations.spec.js, not sure why. Maybe it was removed in the meantime?

[SPGoding]

It deleted __snapshots__/packages/core/test-out/service/Operations.spec.js, not sure why.

the source file was moved from service/ to common/ so that's just an orphan snapshot.

[SPGoding]

LGTM, would be nice if you can update the syntax for TYPED_NUMBER in the mcdoc spec (docs/user/mcdoc/index.adoc) as well. Something like this probably works but it's been a while since I've worked on that punctuation soup document:

<<t-typed-number>>::
	<<t-float>> ++[++`d` `D` `f` `F`++]++^?^ | +
	<<t-integer>> ++[++`b` `B` `l` `L` `s` `S`++]++^?^

[NeunEinser]

(rebase, no new commits)

[TheAfroOfDoom]

requested myself as a non-blocking reviewer so i remember to look at this eventually

[TheAfroOfDoom]

couple smaller things. generally this seems like a good idea though, nice work 😸

---

@SPGoding what are your thoughts on removing /__snapshots__/** linguist-generated=true from .gitattributes?

i guess they technically are generated, but it'd be nice if they weren't auto not rendered in the Files changed view. i find myself definitely wanting to review each snapshot change for robustness

---

similarly, why is README.md set as linguist-generated=true?

[TheAfroOfDoom]

i might prefer we move these file deletions into a separate PR that removes the orphaned snapshots? as-is in here it's almost implying that these mcdoc type changes caused these file diffs

[TheAfroOfDoom]

maybe more leg-work than is worth though

[NeunEinser]

I could revert the changes to these deleted files, just not sure if it's wanted.

[TheAfroOfDoom]

eh its probably fine to keep as-is. would be nice if we eventually had a script to check for orphaned snapshots in GHA

[SPGoding]

what are your thoughts on removing /snapshots/** linguist-generated=true from .gitattributes?

i agree

similarly, why is README.md set as linguist-generated=true?

it used to have automatically generated contributor information. i guess we can remove this as well.