Suggested improvements for ”The Interpreter” #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made changes to text snippets like "The following snippet shows" because the rendering of the book does not guarantee that a snippet follows the paragraph with such a sentence.
There are several listings that are rendered outside the sections where they are referred to. That is confusing for the reader because suddenly code is shown in contexts where the code does not belong. It is a general issue with the rendering. We had the same issue with the Spec book. Is there a solution to keep the figures and listings inside the section where they are included?
Note that listings 6-4, 6-9, 6-10, 6-14 and 6-15 are not referenced in the text with references
Listing *@some_anchor@*. I did not fix that.