Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested improvements for ”The Spur Memory Manager Overview” #24

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

koendehondt
Copy link
Collaborator

I know that this chapter is not ready yet, but I already made some suggestions for improvement.

I have a few other comments:

  • In section 9.1, it reads "This is an important point for the Foreign Function Interface - as you can read in the corresponding book.". It would be good to reference the exact book and add it to the bibliography.
  • The chapter consists of several files. memoryStructure.md ends with a header "Conclusion". Probably it has to be removed.
  • In section 9.8 "The New Space", there is some unformatted text.
  • Section 9.10 "The Scavenger" uses the terms remember table and remembered set. Are they the same concept? That is unclear.
  • In section 9.10 there are several to-do notes, but that is not clear in the PDF. That is confusing. Maybe use the word "TODO" in the text.
  • Section 9.12 has a heading "to be continued", but is empty.
  • Section 9.13 "The Old Space" has a bullet list with concepts shown in figure 9-4. However, freeTree and freeLists are not included in the figure.
  • Section 9.14 "The Free List" and section 9.16 "Free list" have a similar heading.

@guillep guillep merged commit d3d6a13 into master Jan 6, 2025
2 of 3 checks passed
@guillep guillep deleted the kdh-review-chapter-9 branch January 6, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants