Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested improvements for ”Adding Static Methods” #26

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

koendehondt
Copy link
Collaborator

Besides the suggestions in this PR, I have some comments:

  • In section 13.8, the method selector is missing from:
We also define a class method
IRSendStatic class >>
  • At the end of section 13.13, https://github.com/evref-inria/pharo-vm/pull/2/files is coming out of nowhere. Probably it can be removed, but I did not do it because I do not know what the intention of the author was.
  • In section 13.14, there is a paragraph starting with "Need more discussions". It is not clear whether or not this paragraph describes a TODO.
  • In section 13.15 "Limits and conclusion", it reads "This tutorial misses:" and then a list. Is that an indication of a TODO, or is that the final text?

@guillep guillep merged commit 164adc9 into master Jan 6, 2025
2 of 3 checks passed
@guillep guillep deleted the kdh-review-chapter-13 branch January 6, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants