Skip to content

Commit

Permalink
feat: use an external link with arrow for speaker URL
Browse files Browse the repository at this point in the history
  • Loading branch information
astorije committed Aug 15, 2024
1 parent 6407186 commit aa3abc2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
5 changes: 2 additions & 3 deletions app/components/AnchorWithArrow.css.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { style } from "@vanilla-extract/css";

export const anchor = style({
display: "flex",
gap: "0.25em",
justifyContent: "flex-start",
display: "inline-flex",
alignItems: "center",

Check failure on line 5 in app/components/AnchorWithArrow.css.ts

View workflow job for this annotation

GitHub Actions / lint

Expected "alignItems" to come before "display"
});

export const arrow = style({
Expand Down
1 change: 0 additions & 1 deletion app/components/AnchorWithArrow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ export function AnchorWithArrow({ children, href }: AnchorWithArrowProps) {
href={href}
rel="noreferrer"
target="_blank"
variant="heavy"
>
{children}
<Arrow className={styles.arrow} label="" variant="out" />
Expand Down
4 changes: 3 additions & 1 deletion app/components/EventDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ export function EventDetails({ active, event }: EventDetailsProps) {
{" "}
by{" "}
{topic.author.url ? (
<a href={topic.author.url}>{topic.author.name}</a>
<AnchorWithArrow href={topic.author.url}>
{topic.author.name}
</AnchorWithArrow>
) : (
topic.author.name
)}
Expand Down

0 comments on commit aa3abc2

Please sign in to comment.