Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redirect to create a canonical short URL for donations (and others to come) #350

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

astorije
Copy link
Collaborator

@astorije astorije commented Nov 8, 2024

PR Checklist

Overview

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boston-ts-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 8:49pm

@astorije
Copy link
Collaborator Author

astorije commented Nov 8, 2024

@JoshuaKGoldberg I don't know if it's the ideal way to do this but... it seems to work 🤷‍♂️
Not exactly how https://vercel.com/docs/edge-network/redirects recommends it although it seems simpler this way (thanks, ChatGPT).
Thoughts?

Any suggestions for other URLs to "shorten"? We can add some per-events like Q&A, wifi information, etc. but that's for later, as needed. I'm going to think about other ideas, this one's a start.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it works!

- **feat(feedback): add redirect**


## PR Checklist

- [ ] Addresses an existing open issue: fixes #000
- [ ] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/boston-ts-website/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [X] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/boston-ts-website/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview


This makes it so we can change where the form is hosted easily. I make
it not permanent. The reason for `permanent: false` is that it changes
the status code to 307 from 308. 308 status code gets SEO ranking and
probably (not documented) some caching. Since the URL is subject to
change, we do not want to SEO rank the google form.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/307
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/308
🐢
@astorije astorije marked this pull request as ready for review November 19, 2024 20:49
@astorije astorije merged commit 6494c6a into main Nov 19, 2024
11 checks passed
@astorije astorije deleted the astorije/redirects branch November 19, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants