-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Ensure we don't create stub for generated stub executables #1355
base: master
Are you sure you want to change the base?
Conversation
return rootPath.GetAllFilesRecursively("*"); | ||
} | ||
|
||
public static IEnumerable<FileInfo> GetAllFilesRecursively(this DirectoryInfo rootPath, string searchPattern) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a function now? It does the same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to have an overload that takes the search pattern as a parameter (to be used when collectiong exe files for stub creation)
What does this do? Can you fill in the description describing what problem this is trying to solve? |
Hey @paulcbetts , |
Issue:
If we have a lot of files that are enumerated through the call to GetAllFilesRecursively we end up in the situation where we also enumerate over the newly created stub executables.
From this point two thing happen:
Fix:
To ensure this does not happen we force a call to ToList() such that we get the list of executables for which to create the stubs.