-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logging to Releasify #1432
Open
Horb
wants to merge
9
commits into
Squirrel:master
Choose a base branch
from
Horb:feature/AddReleasifyLogging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Logging to Releasify #1432
Commits on Jan 2, 2019
-
The following refactor was brought about because we (Age Partnership) were running into difficulty using Squirrel in the Azure DevOps Build Pipelines and existing logging wasn't sufficient for our needs. I don't expect any functionality to have changed. The Releasify method in Update.exe has been broken up into; * ensureConsole * ReleasifyValidateBaseUrl * ReleasifyValidatePaths * ReleasifyPrepareFiles * ReleasifyProcessFiles * ReleasifyCleanupFiles * ReleasifyWriteReleaseFile * ReleasifyCreateSetupExe * ReleasifyGenerateMsi Breaking Releasify up into smaller methods allows stack traces to be more useful when identifying issues. The refactoring was done using ReSharper. Only significant change is the use of `out var` declarations and passing variables using `ref`. I expect a more significant refactor could make this cleaner. Debug logs have been added to the start of each method and the whole Releasify method is now in a "try / catch / log / throw" block.
Configuration menu - View commit details
-
Copy full SHA for 5ba59ae - Browse repository at this point
Copy the full SHA 5ba59aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 875fe58 - Browse repository at this point
Copy the full SHA 875fe58View commit details -
Configuration menu - View commit details
-
Copy full SHA for df3e46c - Browse repository at this point
Copy the full SHA df3e46cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67fa86e - Browse repository at this point
Copy the full SHA 67fa86eView commit details -
Configuration menu - View commit details
-
Copy full SHA for df8d964 - Browse repository at this point
Copy the full SHA df8d964View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17314f2 - Browse repository at this point
Copy the full SHA 17314f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f184389 - Browse repository at this point
Copy the full SHA f184389View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed47148 - Browse repository at this point
Copy the full SHA ed47148View commit details
Commits on Jan 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 06fc423 - Browse repository at this point
Copy the full SHA 06fc423View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.