Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding genomad version 1.9.0 #1209

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

erinyoung
Copy link
Contributor

There's a new version of genomad! Actually, there are a few versions (including one that came out WHILE I was updating the files).

According to the release notes

There is a new version of mmseqs (17-b804f) but not aragorn, so I've updated the tool-specific readme.

For this PR, I copied the files from 1.8.1 and changes the version args for mmseqs and genomad. I changed the as to AS and moved the CMD line to json format.

The full diff:

$ diff build-files/genomad/1.8.1/Dockerfile build-files/genomad/1.11.0/Dockerfile 
2c2
< ARG GENOMAD_VER="1.8.1"
---
> ARG GENOMAD_VER="1.11.0"
4c4
< ARG MMSEQS2_VER="15-6f452"
---
> ARG MMSEQS2_VER="17-b804f"
6c6
< FROM ubuntu:jammy as builder
---
> FROM ubuntu:jammy AS builder
22c22
< FROM ubuntu:jammy as app
---
> FROM ubuntu:jammy AS app
62c62
< RUN genomad download-database . 
---
> RUN genomad download-database .
65c65
< CMD genomad --help
---
> CMD ["genomad", "--help"]
70c70
< FROM app as test
---
> FROM app AS test

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant