Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding poppunk version 2.7.5 #1224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erinyoung
Copy link
Contributor

There's a new version of poppunk! (Actually there's been a few)

According to the release notes there is more efficient visualization and some fixes. Among other things.

I copied the files from 2.6.5, added a CMD line, updated the base to mambaorg/micromamba:2.0.5-ubuntu22.04, added a cmp line to after the test, and changed as to AS for my linter.

The full diff:

$ diff build-files/poppunk/2.6.5/Dockerfile build-files/poppunk/2.7.5/Dockerfile 
1c1
< FROM mambaorg/micromamba:1.5.6 as app
---
> FROM mambaorg/micromamba:2.0.5-ubuntu22.04 AS app
5c5
< ARG POPPUNK_VERSION="2.6.5"
---
> ARG POPPUNK_VERSION="2.7.5"
12c12
< LABEL base.image="mambaorg/micromamba:1.5.6"
---
> LABEL base.image="mambaorg/micromamba:2.0.5-ubuntu22.04"
39a40,41
> CMD ["poppunk", "--help"]
> 
44c46
< FROM app as test
---
> FROM app AS test
61c63
< RUN bash test.sh
---
> RUN bash test.sh && cmp assigned.csv database.csv

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant