Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding seqfu version 1.22.3 #1232

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

erinyoung
Copy link
Contributor

There's a new version of seqfu!

According to the release notes, there is a bug fix with cat.

I copied the files from 1.20.3 and updated the versions for both seqfu and nim. I also updated the base image from focal to jammy. I converted the CMD layer to json format. I added the -q flag to the wget layer.

The full diff

$ diff build-files/seqfu/1.2*/Dockerfile
2,3c2,3
< ARG SEQFU_VER="1.20.3"
< ARG NIM_VER="1.22.2"
---
> ARG SEQFU_VER="1.22.3"
> ARG NIM_VER="2.2.2"
6c6
< FROM ubuntu:focal AS builder
---
> FROM ubuntu:jammy AS builder
9,12d8
< # Set non-interactive frontend and update PATH
< ENV DEBIAN_FRONTEND=noninteractive \
<     PATH="/root/.nimble/bin:${PATH}"
< 
31a28,29
> ENV PATH="/root/.nimble/bin:${PATH}"
> 
33c31
< RUN wget https://github.com/telatin/seqfu2/archive/refs/tags/v${SEQFU_VER}.tar.gz && \
---
> RUN wget -q https://github.com/telatin/seqfu2/archive/refs/tags/v${SEQFU_VER}.tar.gz && \
40c38
< FROM ubuntu:focal AS app
---
> FROM ubuntu:jammy AS app
44c42
< LABEL base.image="ubuntu:focal" 
---
> LABEL base.image="ubuntu:jammy" 
67c65
< CMD seqfu --help
---
> CMD ["seqfu", "--help"]

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant