feat: Added support for slider widget #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyanshub024
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Once again thanks for an amazing PR, @ishanvaghani 🎉. Please check my suggestions.
.vscode/launch.json
Outdated
| @@ -0,0 +1,25 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we please remove the launch.json file? For mirai I wish to keep the configuration file locally.
| MiraiSlider getModel(Map<String, dynamic> json) => MiraiSlider.fromJson(json); | ||
|
|
||
| @override | ||
| String get type => WidgetType.slider.name; |
There was a problem hiding this comment.
Can we please move the type method to come first, before the getModal method?
| @@ -1,7 +1,7 @@ | |||
| # CircularProgressIndicator | |||
|
|
|||
| Mirai circularProgressIndicator allows you to build the Flutter CircularProgressIndicator widget using JSON. | |||
| To know more about the container widget in Flutter, refer to the [official documentation](https://api.flutter.dev/flutter/material/CircularProgressIndicator-class.html). | |||
| To know more about the CircularProgressIndicator widget in Flutter, refer to the [official documentation](https://api.flutter.dev/flutter/material/CircularProgressIndicator-class.html). | |||
There was a problem hiding this comment.
Thanks for the correction 🙏🏻
website/docs/widgets/slider.md
Outdated
| | autofocus | `bool` | True if this widget will be selected as the initial focus when no other node in its scope is currently focused. | | ||
| | allowedInteraction | `SliderInteraction` | Allowed way for the user to interact with the slider. | | ||
|
|
||
|
|
There was a problem hiding this comment.
Can you please remove the extra line?
|
Resolved all the comments |
divyanshub024
requested changes
Jan 10, 2025
website/docs/widgets/slider.md
Outdated
| | autofocus | `bool` | True if this widget will be selected as the initial focus when no other node in its scope is currently focused. | | ||
| | allowedInteraction | `SliderInteraction` | Allowed way for the user to interact with the slider. | | ||
|
|
||
|
|
There was a problem hiding this comment.
@ishanvaghani Can you check this one? I can still see 2 empty lines at line no. 29 & 30.
There was a problem hiding this comment.
Done removed one line
divyanshub024
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for slider widget.
Added VS Code launch modes file.
Resolved mistakes in documentation.
Screenshots
XRecorder_09012025_211216.mp4
Related Issues
Issue not listed
Type of Change