Track client-initiated shutdown for any pipe type #2814
+11
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2652
Previously,
RecordQuit
only recorded a client-initiatedQUIT
if_ioPipe
was aSocketConnection
, which is not true when using SSL.Since there is a 1-1 relationship between
PhysicalConnection
and_ioPipe
, store whether the client initiated the shutdown on thePhysicalConnection
object instead of (only) delegating it toSocketConnection
.The line
var pipe = connectingPipe ?? _ioPipe
seems irrelevant to this PR becauseconnectingPipe
is only set once, inConnectedAsync
, and would be relevant only if an exception were thrown between whenpipe
is set and when its value is assigned to_ioPipe
(i.e., between lines 1612-15).