Use up-to-date releases of Redis for CI workflow #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set target as 7.4.0 both for ubuntu and windows tests fetch dept check old values path fix start all stack server fix step checkout docker image redis:7.4.2
|
@atakavci I have been checking on our ability to run Redis in Docker from Windows agents and did not realize it had finally happened. This is awesome. I need to find time to get the test suite reliably stable, that's the main thing standing in the way a lot of days, but this looks great. Trying to get a minor release out for a known cluster issue then will get this in. |
NickCraver
reviewed
Mar 8, 2025
| echo "Checking redis-server version with port 26380" | ||
| redis-cli -p 26380 INFO SERVER | grep redis_version || echo "Failed to get version for port 26380" | ||
| echo "Checking redis-server version with port 26381" | ||
| redis-cli -p 26381 INFO SERVER | grep redis_version || echo "Failed to get version for port 26381" |
There was a problem hiding this comment.
Do we need to maintain this separate list anymore? Or can we spin up with compose entirely?
There was a problem hiding this comment.
this is a WSL setup and AFAIK docker support still not available.
But the portion with lots of redis-cli only stands for debugging purposes, let me know if you'd like to get rid of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the Redis versions running in the CI, there are two different test setups according to environments, one on Ubuntu and the other on Windows;
Setup for Windows essentially leverages wsl setup on windows and install+run the version of Redis from its own package repository. The rest is similar to existing approach, using the same config files etc..