-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add language dropdown to code_block nodes #104
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for stacks-editor ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@aaronshekey One of the reasons I didn't go with the If possible, I don't want to break the flow of the doc by placing the select outside of the code_block. Perhaps, we could hide that select if the user's cursor isn't in the node or take a similar approach as Jira: |
# Conflicts: # src/rich-text/node-views/code-block.ts
c29b9e1
to
95bc70e
Compare
1e96950
to
3e4c847
Compare
79dbe6c
to
a852d7a
Compare
In reference to the JIRA ticket and other chat threads in Slack: @b-kelly I was thinking something like this Much of this is taken from what Collectives is doing for their tag dropdown like we talked about in chat. For the code selector though, we’d need to have the dropdown show at the bottom of the code block so that it doesn't block the middle of where people are typing any time they click into a part of the code block. In the screenshot above I have it default to no language selected, but it seems like maybe we should have PlainText as the default? |
Adds the ability to choose the language for codeblocks in richtext mode. Opening as a draft because all the code is there, but it needs a design pass before being merged.
Fixes #28