Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(fundamentals): fix example-row-detail positioning #1859

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

docs(fundamentals): fix example-row-detail positioning #1859

wants to merge 1 commit into from

Conversation

dancormier
Copy link
Contributor

STACKS-657

This PR resolves positioning issues with the annotations used in color fundamentals docs page.

Before

image
image

After

image
image

How to test

  1. Spin this PR up locally (npm run start)
  2. Head to the Color Fundamentals page
  3. Verify that the annotations under each of the monochromatic color strips are positioned as expected
  4. Bonus: Since this fix necessitated changes to the accessibility docs code, verify that annotations under examples are positioned as expected

@dancormier dancormier added the docs Issues with the documentation site label Nov 22, 2024
@dancormier dancormier requested review from CGuindon and a team November 22, 2024 15:59
@netlify Netlify
Copy link

netlify bot commented Nov 22, 2024 •
edited
Loading

❌ Deploy Preview for stacks failed. Why did it fail? →

Name Link
🔨 Latest commit bdc4024
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/6740aa516a61610008df621c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGuindon CGuindon Awaiting requested review from CGuindon

Assignees
No one assigned
Labels
docs Issues with the documentation site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dancormier