Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generated actions for #3 #4

Conversation

nmaludy
Copy link
Contributor

@nmaludy nmaludy commented Oct 13, 2017

Wanted to separate out the auto-generated action noise from the base code that does the real "work".

Note: this depends on #3

Copy link
Collaborator

@nullkarma nullkarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding #3 about the action names. Separating compute_profiles_compute_attributes_compute_profile_id_compute_updateresources with a dot after the endpoint. What do you think? compute_profile.compute_attribute_...

enabled: true
runner_type: "python-script"
entry_point: lib/action.py
name: compute_profiles_compute_attributes_compute_profile_id_compute_updateresources
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what i meant in #3 . Might be very hard to read

@nmaludy
Copy link
Contributor Author

nmaludy commented Oct 18, 2017

@nullkarma Updated to have the format: <endpoint>.<operation>

@nullkarma nullkarma merged commit cfc6a3f into StackStorm-Exchange:master Oct 18, 2017
nmaludy added a commit that referenced this pull request Sep 24, 2019
Merge from upstream into this fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants